Maximum call stack size exceeded

[simllll]

Do you want to request a feature or report a bug?
bug

What is the current behavior?
there are some other issues out there with maximum call stack size exceeded, but I#m unsure if they are related to this one:

[13.07.2021 11:15.30.785] [ERROR] RangeError: Maximum call stack size exceeded
--
  | 2021-07-13T11:15:30.785+02:00 | at handleCallback (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:34:5)
  | 2021-07-13T11:15:30.785+02:00 | at nextFunction (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:867:5)
  | 2021-07-13T11:15:30.785+02:00 | at Cursor._next (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:202:5)
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:249:14
  | 2021-07-13T11:15:30.785+02:00 | at maybePromise (/app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:692:3)
  | 2021-07-13T11:15:30.785+02:00 | at Cursor.next (/app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:234:12)
  | 2021-07-13T11:15:30.785+02:00 | at Object._onNext (/app/node_modules/mongoose/lib/cursor/QueryCursor.js:422:21)
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:704:5
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:252:9
  | 2021-07-13T11:15:30.785+02:00 | at handleCallback (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:32:5)
  | 2021-07-13T11:15:30.785+02:00 | at nextFunction (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:867:5)
  | 2021-07-13T11:15:30.785+02:00 | at Cursor._next (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:202:5)
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:249:14
  | 2021-07-13T11:15:30.785+02:00 | at maybePromise (/app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:692:3)
  | 2021-07-13T11:15:30.785+02:00 | at Cursor.next (/app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:234:12)
  | 2021-07-13T11:15:30.785+02:00 | at Object._onNext (/app/node_modules/mongoose/lib/cursor/QueryCursor.js:422:21)
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:704:5
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:252:9
  | 2021-07-13T11:15:30.785+02:00 | at handleCallback (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:32:5)
  | 2021-07-13T11:15:30.785+02:00 | at nextFunction (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:867:5)
  | 2021-07-13T11:15:30.785+02:00 | at Cursor._next (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:202:5)
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:249:14
  | 2021-07-13T11:15:30.785+02:00 | at maybePromise (/app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:692:3)
  | 2021-07-13T11:15:30.785+02:00 | at Cursor.next (/app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:234:12)
  | 2021-07-13T11:15:30.785+02:00 | at Object._onNext (/app/node_modules/mongoose/lib/cursor/QueryCursor.js:422:21)
  | 2021-07-13T11:15:30.785+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:704:5
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:252:9
  | 2021-07-13T11:15:30.786+02:00 | at handleCallback (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:32:5)
  | 2021-07-13T11:15:30.786+02:00 | at nextFunction (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:867:5)
  | 2021-07-13T11:15:30.786+02:00 | at Cursor._next (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:202:5)
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:249:14
  | 2021-07-13T11:15:30.786+02:00 | at maybePromise (/app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:692:3)
  | 2021-07-13T11:15:30.786+02:00 | at Cursor.next (/app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:234:12)
  | 2021-07-13T11:15:30.786+02:00 | at Object._onNext (/app/node_modules/mongoose/lib/cursor/QueryCursor.js:422:21)
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:704:5
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:252:9
  | 2021-07-13T11:15:30.786+02:00 | at handleCallback (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:32:5)
  | 2021-07-13T11:15:30.786+02:00 | at nextFunction (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:867:5)
  | 2021-07-13T11:15:30.786+02:00 | at Cursor._next (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:202:5)
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:249:14
  | 2021-07-13T11:15:30.786+02:00 | at maybePromise (/app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:692:3)
  | 2021-07-13T11:15:30.786+02:00 | at Cursor.next (/app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:234:12)
  | 2021-07-13T11:15:30.786+02:00 | at Object._onNext (/app/node_modules/mongoose/lib/cursor/QueryCursor.js:422:21)
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:704:5
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:252:9
  | 2021-07-13T11:15:30.786+02:00 | at handleCallback (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:32:5)
  | 2021-07-13T11:15:30.786+02:00 | at nextFunction (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:867:5)
  | 2021-07-13T11:15:30.786+02:00 | at Cursor._next (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:202:5)
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:249:14
  | 2021-07-13T11:15:30.786+02:00 | at maybePromise (/app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:692:3)
  | 2021-07-13T11:15:30.786+02:00 | at Cursor.next (/app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:234:12)
  | 2021-07-13T11:15:30.786+02:00 | at Object._onNext (/app/node_modules/mongoose/lib/cursor/QueryCursor.js:422:21)
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/utils.js:704:5
  | 2021-07-13T11:15:30.786+02:00 | at /app/node_modules/mongoose/node_modules/mongodb/lib/cursor.js:252:9
  | 2021-07-13T11:15:30.786+02:00 | at handleCallback (/app/node_modules/mongoose/node_modules/mongodb/lib/core/cursor.js:32:5)

If the current behavior is a bug, please provide the steps to reproduce.
I cannot really reproduce it, as it seems it only happens from time to time, but it crashes the whole node process after that.
I see following strange behaviours:

1. JSON.stringify(mongooseModelResult[0].someProperty) returns e.g. { a: 1 }, but Object.values(mongooseModelResult[0].someProperty) returns something complete different? This reminds me of a memory issue in good old c? This issue is gone if I use .lean() for the query... still doesn't seem right.
   The related has this structure:

user.privacy: {
		user_register: Date,
		user_application: Date,
		user_active_sourcing: Date,
		company_register: Date,
		company_posting: Date,
		company_application: Date,
		company_club: Date,
		company_digital_content: Date
	},

with one data point set:

user.privacy: {
user_register: some-Date
}

after the mongoose result, I add some more data to the object, in this case I added to the root object "user.mailBounces = {...}".
when I use Object.values of user.privacy I get also the mailBounces values returned?
2. For some models and queries it seems if I use populate the call stack size exceeded error appears. It only helps to remove populate from these kind of queries. THe strange thing is: it seems to be related with the data of the collecitno, as this is only happening for us on produciton, but not on the test environment?
3. The error above: The main issue with that is that I cannot even say where it is coming from, as the stacktrace doesn't let me debug this. But I guess it has something similar like point 2.

{
	"compilerOptions": {
		// https://node.green/#ES2020
		"module": "commonjs",
		"target": "es2020",
		"lib": ["es2020"],

		// other best practice configs
		"noUncheckedIndexedAccess": true,
		"moduleResolution": "node",
		"strict": true,
		"noImplicitAny": false, 
		"removeComments": false,
		"emitDecoratorMetadata": true,
		"composite": true,
		"experimentalDecorators": true,
		"strictPropertyInitialization": false,
		"resolveJsonModule": true,
		"sourceMap": true,
		"isolatedModules": false,
		"declaration": true,
		"skipLibCheck": true,
		"noImplicitOverride": true
	},
	"files": ["types/lib.shim.d.ts", "types/mongoose.d.ts"],
	"exclude": ["node_modules", "**/__tests__"]
}

I put all these 3 issues into one ticket, as I hardly believe this is all related with virtuals somehow?

What is the expected behavior?
no errors, I just recently upgraded from
"mongoose": "5.10.19",
to
"mongoose": "^5.13.2",
..there were no issues with 5.10.19.

What are the versions of Node.js, Mongoose and MongoDB you are using? Note that "latest" is not a version.
mongoose: 5.13.12
node: v16.4.0
mongodb: 4.4.1

[IslandRhythms]

JSON.stringify(mongooseModelResult[0].someProperty) returns e.g. { a: 1 }, but Object.values(mongooseModelResult[0].someProperty) returns something complete different? This reminds me of a memory issue in good old c? This issue is gone if I use .lean() for the query... still doesn't seem right.
The related has this structure:

Object.values would return the values in the key value pair so instead of returning {a:1} it will just return 1.

Please provide a script that demonstrates these issues you have

[CraigglesO]

I can comment on this. The cursor doesn't clean up after itself, so if you have millions of data points, it will eventually use up too much:

Here is a simplified version of my script:

const fs = require('fs')
const mongoose = require('mongoose')
const log = require('single-line-log').stdout

const PlacePointModel = require('./schema/PlacePoint.js').PlacePointModel

let total = 0

async function BUILD () {
  await mongoose.connect('mongodb://127.0.0.1:27017/data', {
    useNewUrlParser: true,
    useUnifiedTopology: true,
    useFindAndModify: false,
    useCreateIndex: true
  })

  const db = mongoose.connection

  const pointCursor = PlacePointModel.find().populate('relations').cursor()

  for (let point = await pointCursor.next(); point != null; point = await pointCursor.next()) {
    log(++total)
    // pull
    const { ... } = point
    // manipulate

    ...

    // store
    fs.appendFileSync('./data.json', JSON.stringify(feature) + '\n')
  }

  db.close()
}

BUILD()

version of node: 12.22.3
mongoose: 5.13.2

[simllll]

JSON.stringify(mongooseModelResult[0].someProperty) returns e.g. { a: 1 }, but Object.values(mongooseModelResult[0].someProperty) returns something complete different? This reminds me of a memory issue in good old c? This issue is gone if I use .lean() for the query... still doesn't seem right.
The related has this structure:

Object.values would return the values in the key value pair so instead of returning {a:1} it will just return 1.

Please provide a script that demonstrates these issues you have

Sorry, I meant Object.entries, but the main culprit here is that it reported values/keys/content which is not part of the original object.

Simplified version of a scirpt that produces this errornous output:

import 'reflect-metadata';
import { DBUserModel } from '@hokify/user-data';
import { DBMailBounceModel } from '@hokify/messaging-servicefeedback';
import { ObjectId } from 'mongodb';
import { MongooseConnection } from '../src';

(async () => {
	await MongooseConnection.connect();

        // fetch a user object 
	const selUser = await DBUserModel.findOne({
		_id: new ObjectId('60e61c0dd8c15500190e031b')
	}).exec();

        // fetc mail bounces
	await DBMailBounceModel.findOne({ email: selUser.general.email })
		.exec()
		.then(bounce => {
			selUser.mailBounce = bounce;
		});

	console.log('selUser.mailBounce', selUser.mailBounce);

	console.log('selUser.privacy', selUser.privacy);
	console.log('JSON.stringify(selUser.privacy)', JSON.stringify(selUser.privacy));
	console.log('Object.keys(selUser.privacy)', Object.keys(selUser.privacy));
	console.log(
		'Object.entries(selUser.privacy)',
		Object.entries(selUser.privacy).map(
			([key, _value]) => `privacy[${key}]` + `: ${selUser.privacy[key] ? 'Exists' : ' FAIL'}`
		)
	);
})();

and the output of this scirpt:

selUser.mailBounce {
  amount: 1,
  _id: 60ebe31dd4b4c9cf128712cb,
  email: 'ewald_dresbach@yahoo.it',
  __v: 0,
  createdAt: 2021-07-12T06:37:17.224Z,
  lastError: 'Permanent, General / failed:smtp; 552 1 Requested mail action aborted, mailbox not found',
  updatedAt: 2021-07-12T06:37:17.224Z
}
selUser.privacy { user_register: 2021-07-07T21:26:37.934Z }
JSON.stringify(selUser.privacy) {"user_register":"2021-07-07T21:26:37.934Z"}
Object.keys(selUser.privacy) [
  '$init',
  'mailBounce',
  'user_register',
  'user_application',
  'user_active_sourcing',
  'company_register',
  'company_posting',
  'company_application',
  'company_club',
  'company_digital_content'
]
Object.entries(selUser.privacy) [
  'privacy[$init]: Exists',
  'privacy[mailBounce]: Exists',
  'privacy[user_register]: Exists',
  'privacy[user_application]:  FAIL',
  'privacy[user_active_sourcing]:  FAIL',
  'privacy[company_register]:  FAIL',
  'privacy[company_posting]:  FAIL',
  'privacy[company_application]:  FAIL',
  'privacy[company_club]:  FAIL',
  'privacy[company_digital_content]:  FAIL'
]

look at selUser.privacy and JSON.stringify => all good
but look at Object.keys or Object.values => it returns weird other stuff (e.g. it includes mailBoucne?!).
The mongoose model defintion part of the user object for privacy looks like this:

privacy: {
		user_register: Date,
		user_application: Date,
		user_active_sourcing: Date,
		company_register: Date,
		company_posting: Date,
		company_application: Date,
		company_club: Date,
		company_digital_content: Date
	},

there is no such thing as mailBounce.. furthermore if I add .lean() to the user query, all works correctly.

Version checks:

• mongoose 5.10.19: works (no mailBounce within the selUser.privacy)
• mongoose 5.11.20: works
• mongoose 5.12.1: works
• mongoose 5.12.10: works
• mongoose 5.12.12: works
• mongoose 5.12.13: broken
• mongoose 5.12.15: broken
• mongoose 5.13.2: broken

so it seems the bug got introduced in 5.12.13.

not quite sure if this is bug is directly related to the e.g. non freeing cursors issues? is this somehow related? @CraigglesO can you verify if the cursor issue also got introduced in 5.12.13?

[IslandRhythms]

Please include your models @simllll

[IslandRhythms]

@CraigglesO Please define what feature is suppose to be along with the {...} = point as well as your model

[simllll]

Please include your models @simllll

const userSchema = new Schema({
		general: {
			email: { type: String, lowercase: true, trim: true },
		},
		privacy: {
			user_register: Date,
			user_application: Date,
			user_active_sourcing: Date,
			company_register: Date,
			company_posting: Date,
			company_application: Date,
			company_club: Date,
			company_digital_content: Date
		}
	});

	const DBUserModel = model('UserMongooseBug', userSchema);

	await DBUserModel.create({
		general: {
			email: 'test'
		},
		privacy: {
			user_register: new Date()
		}
	});

	const mailBounceSchema = new Schema(
		{
			email: {
				type: String,
				unique: true,
				required: true,
				dropDups: true
			},
			amount: { type: Number, default: 0 },
			lastError: Schema.Types.Mixed
		},
		{
			timestamps: true
		}
	);

	const DBMailBounceModel = model('MailBounceMongooseBug', mailBounceSchema);

	await DBUserModel.create({
		email: 'test',
		amount: 1,
		lastError: {
			bla: true
		}
	});

[IslandRhythms]

const mongoose = require('mongoose');

const userSchema = new mongoose.Schema({
	general: {
		email: { type: String, lowercase: true, trim: true },
	},
	privacy: {
		user_register: Date,
		user_application: Date,
		user_active_sourcing: Date,
		company_register: Date,
		company_posting: Date,
		company_application: Date,
		company_club: Date,
		company_digital_content: Date
	}
});

const DBUserModel = mongoose.model('UserMongooseBug', userSchema);

const mailBounceSchema = new mongoose.Schema(
	{
		email: {
			type: String,
			unique: true,
			required: true,
			dropDups: true
		},
		amount: { type: Number, default: 0 },
		lastError: mongoose.Schema.Types.Mixed
	},
	{
		timestamps: true
	}
);

const DBMailBounceModel = mongoose.model('MailBounceMongooseBug', mailBounceSchema);

(async () => {
	await mongoose.connect('mongodb://localhost:27017/test', { useNewUrlParser: true, useUnifiedTopology: true });
	await mongoose.connection.dropDatabase();
	
	let general = await DBUserModel.create({
		general: {
			email: 'test'
		},
		privacy: {
			user_register: new Date()
		}
	});

	let entry = await DBUserModel.create({
		email: 'test',
		amount: 1,
		lastError: {
			bla: true
		}
	});
        // fetch a user object 
	const selUser = await DBUserModel.findOne({
		_id: general._id
	}).exec();

        // fetc mail bounces
	await DBMailBounceModel.findOne({ email: selUser.general.email })
		.exec()
		.then(bounce => {
			selUser.mailBounce = bounce;
		});

	console.log('selUser.mailBounce', selUser.mailBounce);

	console.log('selUser.privacy', selUser.privacy);
	console.log('JSON.stringify(selUser.privacy)', JSON.stringify(selUser.privacy));
	console.log('Object.keys(selUser.privacy)', Object.keys(selUser.privacy));
	console.log(
		'Object.entries(selUser.privacy)',
		Object.entries(selUser.privacy).map(
			([key, _value]) => `privacy[${key}]` + `: ${selUser.privacy[key] ? 'Exists' : ' FAIL'}`
		)
	);
})();

[simllll]

Is this intended that you have added the can't reproduce label @IslandRhythms ? If i run your script with mongoose ^5.13.3:

JSON.stringify(selUser.privacy) {"user_register":"2021-07-20T10:24:27.938Z"}
Object.keys(selUser.privacy) [
  '$init',
  'mailBounce',
  'user_register',
  'user_application',
  'user_active_sourcing',
  'company_register',
  'company_posting',
  'company_application',
  'company_club',
  'company_digital_content'
]
Object.entries(selUser.privacy) [
  'privacy[$init]: Exists',
  'privacy[mailBounce]:  FAIL',
  'privacy[user_register]: Exists',
  'privacy[user_application]:  FAIL',
  'privacy[user_active_sourcing]:  FAIL',
  'privacy[company_register]:  FAIL',
  'privacy[company_posting]:  FAIL',
  'privacy[company_application]:  FAIL',
  'privacy[company_club]:  FAIL',
  'privacy[company_digital_content]:  FAIL'
]

I run with ts-node test.ts, mailBounce popps up inside privacy?
node v16.4.0
mongo v4.4.1 (via mongos)

[IslandRhythms]

My bad, missed the version number