Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in docs for "populate virtual" #10870

Closed
adamreisnz opened this issue Oct 11, 2021 · 3 comments · Fixed by #10890
Closed

Broken link in docs for "populate virtual" #10870

adamreisnz opened this issue Oct 11, 2021 · 3 comments · Fixed by #10890
Assignees
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Milestone

Comments

@adamreisnz
Copy link
Contributor

In this section: https://mongoosejs.com/docs/api/schema.html#schema_Schema-virtual

The link for Marks this as a populate virtual is broken. It points to https://mongoosejs.com/docs/api/populate.html#populate-virtuals which doesn't exist.

The following links for See populate virtual docs for more information are also broken.

I was looking at this section to find out if a virtual with a reference can also be manually set on a document.

@IslandRhythms IslandRhythms added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Oct 12, 2021
@vkarpov15 vkarpov15 added this to the 6.0.12 milestone Oct 14, 2021
@IslandRhythms IslandRhythms linked a pull request Oct 15, 2021 that will close this issue
@adamreisnz
Copy link
Contributor Author

adamreisnz commented Oct 19, 2021

@vkarpov15 @IslandRhythms I'm not sure that PR fixes this issue?

Neither of these links appear to be valid:

https://mongoosejs.com/docs/api/populate.html#populate-virtuals
https://mongoosejs.com/api/populate.html#populate-virtuals

And the /docs part is the only thing this PR seems to add?

image

Also, in my original comment, I note that the URL that it was pointing to already contained /docs, so maybe the whole URL is wrong altogether?

@vkarpov15
Copy link
Collaborator

@adamreisnz
Copy link
Contributor Author

adamreisnz commented Oct 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants