Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] add cursor.eachAsync index parameter #13162

Merged
merged 3 commits into from
Mar 13, 2023
Merged

[6.x] add cursor.eachAsync index parameter #13162

merged 3 commits into from
Mar 13, 2023

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR is a backport of #13153 for 6.x

fixes #13152

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Mar 13, 2023
@hasezoey hasezoey added this to the 6.10.3 milestone Mar 13, 2023
@hasezoey hasezoey linked an issue Mar 13, 2023 that may be closed by this pull request
missing typescript overload for cursor.eachasync #13152
Closed
2 tasks
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍

Uzlopak
Uzlopak approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 merged commit 0b2f6ed into Automattic:6.x Mar 13, 2023
@hasezoey hasezoey deleted the addIndexCursor branch March 13, 2023 17:02
@vkarpov15 vkarpov15 mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
6.10.3
Development

Successfully merging this pull request may close these issues.

missing typescript overload for cursor.eachasync
5 participants
@hasezoey @vkarpov15 @Uzlopak @AbdelrahmanHafez @krosenk729