Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document): add index param to eachAsync fn #13153

Merged
merged 2 commits into from Mar 10, 2023
Merged

fix(document): add index param to eachAsync fn #13153

merged 2 commits into from Mar 10, 2023

Conversation

krosenk729
Copy link
Contributor

Summary

Fix for #13152

Examples

AbdelrahmanHafez
AbdelrahmanHafez requested changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please add a test in test/typescript to prevent that from being accidentally deleted?

@krosenk729
Copy link
Contributor Author

yes thanks for the fast review @AbdelrahmanHafez -- added a test

vkarpov15
vkarpov15 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

I noticed in #13152 you're using Mongoose 6.6.1. Is there anything blocking you from upgrading to Mongoose 7? Since this PR is against master branch, it will go into 7.0.2. But we can also cherry pick this into 6.x.

@vkarpov15 vkarpov15 added this to the 7.0.2 milestone Mar 10, 2023
@vkarpov15 vkarpov15 merged commit 03185af into Automattic:master Mar 10, 2023
@hasezoey hasezoey linked an issue Mar 13, 2023 that may be closed by this pull request
missing typescript overload for cursor.eachasync #13152
Closed
2 tasks
This was referenced Mar 13, 2023
Closed
Merged
@krosenk729
Copy link
Contributor Author

Thanks 👍

I noticed in #13152 you're using Mongoose 6.6.1. Is there anything blocking you from upgrading to Mongoose 7? Since this PR is against master branch, it will go into 7.0.2. But we can also cherry pick this into 6.x.

@vkarpov15 a cherry pick would be much much appreciated. our last upgrade was a little complicated, so we're still gathering resources to devote to another major version bump

@vkarpov15
Copy link
Collaborator

@krosenk729 it looks like this fix was already applied to 6.x here: #13162 . Upgrade to 6.10.3 for the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez requested changes

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

missing typescript overload for cursor.eachasync
3 participants
@krosenk729 @vkarpov15 @AbdelrahmanHafez