required validator on single nested subdoc not working after Schema#clone()

[Vatish12]

Hi, I want to request a feature if it's not available that is a developer should be able to write custom validators for custom nested object that is not a schema.

I am creating a schema like following:

const mediaSkeleton = {
    url: { type: String, required: true },
    thumbUrl: { type: String, required: true },
    mediaType: { type: Number, min: 0, max: 1, required: true },
    aspectRatio: { type: Number, required: true }
}

function requiredObj(x) { 
       console.log(`requiredObj  called for ${x}!`)
       return x != undefined && x != null 
}

const mySchema = new Schema({
       ....
       text: String,
       banner: { type: mediaSkeleton, validate: requiredObj }
       ....
})

I am calling save method on model like following:

const model = mongoose.model("MySchema", mySchema)

await new FaceOffModel(
      { text: "Testing requiredObj validator" }
).save()

requiredObj function doesn't call at all. Please help me to fix it.

[vkarpov15]

const mySchema = new Schema({
       ....
       text: String,
       banner: { type: new Schema(mediaSkeleton), validate: requiredObj } // <-- see `new Schema()` here
       ....
})

This is an unfortunate rough patch in Mongoose's API, we will fix this with #7181

[Jule-]

@vkarpov15 are you sure it works?

I am trying to achieve something like that and I have issues triggering the validation on save on my nested schema pathes.

For me this code is not triggering required validator on path author nor my custom validator function

const authorSchema = new mongoose.Schema({
  name: String,
  pseudonym: String
});

const bookSchema = new mongoose.Schema({
  author: {
    type: authorSchema,
    required: true,
    validate: {
      validator: a => (a.name && a.name.length > 0) || (a.pseudonym && a.pseudonym.length > 0)
    }
  }
});

const Book = mongoose.model('Book', bookSchema);



const book = new Book({});
await book.save(); // return Book instance WITHOUT throwing validation error.

But calling validate on it will throw validation error

await book.validate(); // thow validation error

Did I missed something or is there a workaround to achieve what I want?

[vkarpov15]

@Jule- the below script throws a "Path author is required" error, as expected.

'use strict';

const mongoose = require('mongoose');

mongoose.set('useFindAndModify', false);

const { Schema } = mongoose;

run().catch(err => console.log(err));

async function run() {
  await mongoose.connect('mongodb://localhost:27017/test', {
    useNewUrlParser: true,
    useUnifiedTopology: true
  });

  await mongoose.connection.dropDatabase();

  const authorSchema = new mongoose.Schema({
    name: String,
    pseudonym: String
  });

  const bookSchema = new mongoose.Schema({
    author: {
      type: authorSchema,
      required: true,
      validate: {
        validator: a => (a.name && a.name.length > 0) || (a.pseudonym && a.pseudonym.length > 0)
      }
    }
  });
  const Book = mongoose.model('Book', bookSchema);

  const book = new Book({});
  await book.save(); // return Book instance WITHOUT throwing validation error. 
  console.log('Done');
}

Can you please clarify what version of Mongoose you're using, and modify the above script to demonstrate your issue?

[Jule-]

@vkarpov15 sorry for the delay, I am back!

Thank you, you helped me spotting what is messing things up! 👍
I have set this in my connection code, before creating my Model, of course.

mongoose.set('cloneSchemas', true);

From my point of vue it is a bug, can you confirm that? Or help me understand what can I do to achieve what I want?

Thank you again! 🙂

[Jule-]

And I am using Mongoose version 5.8.9

[Jule-]

Just in order to be clear, the full repro script is:

'use strict';

const mongoose = require('mongoose');

mongoose.set('cloneSchemas', true);
mongoose.set('useFindAndModify', false);

const { Schema } = mongoose;

run().catch(err => console.log(err));

async function run() {
  await mongoose.connect('mongodb://localhost:27017/test', {
    useNewUrlParser: true,
    useUnifiedTopology: true
  });

  await mongoose.connection.dropDatabase();

  const authorSchema = new mongoose.Schema({
    name: String,
    pseudonym: String
  });

  const bookSchema = new mongoose.Schema({
    author: {
      type: authorSchema,
      required: true,
      validate: {
        validator: a => (a.name && a.name.length > 0) || (a.pseudonym && a.pseudonym.length > 0)
      }
    }
  });
  const Book = mongoose.model('Book', bookSchema);

  const book = new Book({});
  await book.save(); // return Book instance WITHOUT throwing validation error.
  console.log('Done');
}

[Jule-]

@vkarpov15 Thank you! 🙏🙂