fix? hooks now return an array only and typescript bugs fixed? #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It passed all the already failing tests but now introduces 4 failures.
vkarpov15
requested changes
Mar 15, 2021
lib/cursor/QueryCursor.js
Outdated
| @@ -480,7 +480,8 @@ function _waitForCursor(ctx, cb) { | |||
| */ | |||
|
|
|||
| function _create(ctx, doc, populatedIds, cb) { | |||
| const instance = helpers.createModel(ctx.query.model, doc, ctx.query._fields); | |||
| doc = [doc]; | |||
There was a problem hiding this comment.
Why is this here? createModel() takes in a single document as a param, not an array.
test/query.cursor.test.js
Outdated
| return co(function*() { | ||
| yield Movie.deleteMany({}); | ||
| yield Movie.create({ name: 'Daniel' }, { name: 'Val' }, { name: 'Daniel' }); | ||
| yield Movie.find({ name: 'Daniel' }).cursor().eachAsync(doc => { |
There was a problem hiding this comment.
eachAsync() should pass a doc, not an array of docs, to the callback. This would be a massive breaking change.
There was a problem hiding this comment.
You only want to change how post hooks work, not how everything else about query cursors works.
vkarpov15
reviewed
Mar 15, 2021
lib/cursor/QueryCursor.js
Outdated
| @@ -480,7 +480,7 @@ function _waitForCursor(ctx, cb) { | |||
| */ | |||
|
|
|||
| function _create(ctx, doc, populatedIds, cb) { | |||
| const instance = helpers.createModel(ctx.query.model, doc, ctx.query._fields); | |||
| const instance = helpers.createModel(ctx.query.model, [doc], ctx.query._fields); | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It passed all the already failing tests but now introduces 4 failures.