fix: make bulkWrite can work with timestamps: false
#10050
Conversation
lib/helpers/model/castBulkWrite.js
Outdated
| @@ -20,7 +20,7 @@ module.exports = function castBulkWrite(originalModel, op, options) { | |||
| const model = decideModelByObject(originalModel, op['insertOne']['document']); | |||
|
|
|||
| const doc = new model(op['insertOne']['document']); | |||
| if (model.schema.options.timestamps != null) { | |||
| if (doc.initializeTimestamps) { | |||
There was a problem hiding this comment.
Shouldn't this be if (model.schema.options.timestamps) ?
There was a problem hiding this comment.
I had considered using it at first, but I tried to find where is also using doc.initializeTimestamps(), and I found this:
Lines 3324 to 3326 in 9cf48f5
So I think it's better to use the same condition, if you need to change it in the future, it will be easier to find where you need to edit.
But it just my opinion, if you think it's better to use if (model.schema.options.timestamps), I can change it.
There was a problem hiding this comment.
I think that is meant to handle a separate case. I'll make the changes on my own and merge this 👍
lib/helpers/model/castBulkWrite.js
Outdated
| @@ -147,7 +147,7 @@ module.exports = function castBulkWrite(originalModel, op, options) { | |||
|
|
|||
| // set `skipId`, otherwise we get "_id field cannot be changed" | |||
| const doc = new model(op['replaceOne']['replacement'], strict, true); | |||
| if (model.schema.options.timestamps != null) { | |||
| if (doc.initializeTimestamps) { | |||
There was a problem hiding this comment.
Similarly, shouldn't this be if (model.schema.options.timestamps)?
Summary
bulkWrite use
if (model.schema.options.timestamps != null)to check that it should runinitializeTimestamps()or not, so it will got error when settimestamps: falsein schema.I saw
Model.$__insertManyuseif (doc.initializeTimestamps)to check, so I make bulkWrite use the same condition to fix issue.Examples
#10048