-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh 10025 #10062
Conversation
Some tests are failing but they were failing before the changes I made.
@@ -70,7 +70,12 @@ function Connection(base) { | |||
this._closeCalled = false; | |||
this._hasOpened = false; | |||
this.plugins = []; | |||
this.id = id++; | |||
// this.id = id++; | |||
if (typeof base === 'undefined' || !base.connections.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just get rid of this if
statement, shouldn't be necessary because Connection
constructor is private so base
should always be a Mongoose instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Some tests are failing but they were failing before I made these changes.