Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(quickstart) remove await for connection, not required as per #10610 #10625

Closed
wants to merge 1 commit into from
Closed

(quickstart) remove await for connection, not required as per #10610 #10625

wants to merge 1 commit into from

Conversation

lorand-horvath
Copy link
Contributor

@lorand-horvath lorand-horvath commented Aug 27, 2021 •
edited

As per #10610 (comment) await is not required anymore. It was only necessary as a temporary workaround of a bug in 6.0.1 which was fixed in 6.0.2 here 86f53ad hasn't been fixed yet, see #10610 (comment)

@lorand-horvath lorand-horvath mentioned this pull request Aug 27, 2021
Closed
vkarpov15
vkarpov15 reviewed Aug 27, 2021
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd err on the side of keeping the await mongoose.connect() logic. It isn't strictly necessary, but I think that fits better with the rest of the example because of my comment.

docs/index.md
```

For brevity, let's assume that all following code is within the `main()` function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep this because we use await in the rest of the code samples.

@lorand-horvath
Copy link
Contributor Author

lorand-horvath commented Aug 27, 2021 •
edited

I'd err on the side of keeping the await mongoose.connect() logic. It isn't strictly necessary, but I think that fits better with the rest of the example because of my comment.

OK, but the bug is still present, it doesn't seem to work without await anyway #10610 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lorand-horvath @vkarpov15