Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed delete and update docs as well as website.js scripts to reflect… #10908

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fixed delete and update docs as well as website.js scripts to reflect… #10908

merged 1 commit into from
Oct 21, 2021

Conversation

IslandRhythms
Copy link
Collaborator

whenever i navigate the site on localhost, this pops up in the console

{
  status: 404,
  headers: { server: 'node-static/0.7.9' },
  message: 'Not Found'
} /docs/api/images/favicon/manifest.json

Everything runs smoothly, and it appears to be an image, so I guess it isn't urgent.

@IslandRhythms IslandRhythms linked an issue Oct 20, 2021 that may be closed by this pull request
docs do not reflect change from {n, nModified, ok} to {modifiedCount, matchedCount} and others #10901
Closed
vkarpov15
vkarpov15 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@vkarpov15 vkarpov15 added this to the 6.0.12 milestone Oct 21, 2021
@vkarpov15 vkarpov15 merged commit 86357df into master Oct 21, 2021
@vkarpov15 vkarpov15 deleted the update-and-delete-doc-fix branch October 21, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.12
Development

Successfully merging this pull request may close these issues.

docs do not reflect change from {n, nModified, ok} to {modifiedCount, matchedCount} and others
2 participants
@IslandRhythms @vkarpov15