[gh-10902 v5] Emit end event in before close #10916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vkarpov15
approved these changes
Oct 29, 2021
lib/cursor/AggregationCursor.js
Outdated
| Readable.call(this, { objectMode: true }); | ||
| const streamOpts = { objectMode: true }; | ||
| // for node < 12 we will emit 'close' event after 'end' | ||
| if (parseInt(process.versions.node.split('.')[0]) >= 12) { |
There was a problem hiding this comment.
Can we make this a static property in lib/utils.js? So instead of parseInt(process.versions.node.split('.')[0]), we'd just do require('../../utils').nodeMajorVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory.
If you're making a change to documentation, do not modify a
.htmlfile directly. Instead find the corresponding.pugfile or test case in thetest/docsdirectory.Summary
The 'end' event should be emit before 'close' event.
See PR from master.
Issue: #10902 (comment)
Examples