Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parenthesis #11330

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Add parenthesis #11330

merged 2 commits into from
Feb 7, 2022

Conversation

apeltop
Copy link
Contributor

@apeltop apeltop commented Feb 4, 2022

There's no problem with existing code because there are no arguments in the function call.
But most other places use parentheses by no arguments in the function call. so I change it .
I think there's a reason why you didn't change it.

Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks 👍 no particular reason for us to prefer new Date over new Date(), the latter is more readable.

@vkarpov15 vkarpov15 added this to the 6.2.1 milestone Feb 7, 2022
@vkarpov15 vkarpov15 merged commit 11a2197 into Automattic:master Feb 7, 2022
@apeltop apeltop deleted the fix-new-parenthesis branch March 18, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants