Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on is no longer a reserved word gh-11580 #11804

Merged
merged 4 commits into from
May 16, 2022
Merged

on is no longer a reserved word gh-11580 #11804

merged 4 commits into from
May 16, 2022

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

@IslandRhythms IslandRhythms linked an issue May 13, 2022 that may be closed by this pull request
Remove on from schema reserved keys #11580
Closed
@AbdelrahmanHafez
Copy link
Collaborator

AbdelrahmanHafez commented May 13, 2022 •
edited

@IslandRhythms
Even if users can use it now, should we remove the warning functionality?
Keeping it under reserved allows us to log a warning when a person uses it, which as far as I understand is still the desired behavior.

What do you think?

LGTM, thanks!

@vkarpov15 vkarpov15 changed the base branch from master to 6.4 May 16, 2022 02:30
vkarpov15
vkarpov15 approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 2dc8de8 into 6.4 May 16, 2022
@hasezoey hasezoey deleted the gh-11580 branch September 1, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove on from schema reserved keys
3 participants
@IslandRhythms @AbdelrahmanHafez @vkarpov15