fix: 馃悰 Types of Connection.deleteModel() #11812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation and the code of Connection.deleteModel() tells, that
it accepts a string and a RegExp. So, the types should accept a RegExp
as well.
Summary
At the moment
moongoose.connection.deleteModel(/.+/)
is not working in the test code in one of my typescript repositories, because of a type error. The javascript code ofdeleteModel
tells, that a RegExp is accepted, but the current types only allow a string as parameter. My current workaround ismongoose.connection.deleteModel(<string><unknown>/.+/)
, what is not ideal in my opinion.Examples
The following line should work in typescript as well:
mongoose.connection.deleteModel(/.+/)