Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed model.remove ignoring callback #1210

Merged
merged 3 commits into from
Nov 14, 2012
Merged

Fixed model.remove ignoring callback #1210

merged 3 commits into from
Nov 14, 2012

Commits on Nov 13, 2012

  1. Fixed model.remove ignoring callback 

    I don't know if this behavior was intended, but it's wrong. 
If I call .remove on the same model twice for whatever reason, second call will never execute callback, which will break execution flow.
    @bratchenko
    bratchenko committed Nov 13, 2012
    Configuration menu
    Copy the full SHA
    1ef516b View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2012

  1. more sensible behavior for second call of .remove 

    just call Promise.addBack with new callback. No need to actually remove model twice.
    @bratchenko
    bratchenko committed Nov 14, 2012
    Configuration menu
    Copy the full SHA
    28ffd4d View commit details
    Browse the repository at this point in the history

  2. returned missing newline

    @bratchenko
    bratchenko committed Nov 14, 2012
    Configuration menu
    Copy the full SHA
    6c80377 View commit details
    Browse the repository at this point in the history