Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added findById type definitions #12309

Merged
merged 1 commit into from Aug 22, 2022
Merged

Added findById type definitions #12309

merged 1 commit into from Aug 22, 2022

Conversation

lpizzinidev
Copy link
Contributor

Closes #12286

AbdelrahmanHafez
AbdelrahmanHafez approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@AbdelrahmanHafez AbdelrahmanHafez added this to the 6.5.3 milestone Aug 22, 2022
@AbdelrahmanHafez AbdelrahmanHafez added the typescript Types or Types-test related issue / Pull Request label Aug 22, 2022
@AbdelrahmanHafez AbdelrahmanHafez merged commit 59dd6af into Automattic:master Aug 22, 2022
AbdelrahmanHafez added a commit that referenced this pull request Aug 22, 2022
@AbdelrahmanHafez
test(types): add type test re #12286 #12309
32bb9a2
@gterras gterras mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
6.5.3
Development

Successfully merging this pull request may close these issues.

findById is missing from the Query types
2 participants
@lpizzinidev @AbdelrahmanHafez