types(documentarray): typed DocumentArray constructor parameter #13089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Feb 27, 2023
test/types/docArray.test.ts
Outdated
| expectError(function getTestRouteData(): Route { | ||
| return { | ||
| points: new Types.DocumentArray([ | ||
| { name: 'Test' } // "location" is missing |
There was a problem hiding this comment.
The major problem with this approach is that you'll still get an error even if location has a default.
Even if we work around the defaults issue, still doesn't handle the case of custom getters, or properties that are set in middleware (e.g. timestamps).
types/types.d.ts
Outdated
| @@ -61,7 +61,7 @@ declare module 'mongoose' { | |||
|
|
|||
| class DocumentArray<T> extends Types.Array<T extends Types.Subdocument ? T : Types.Subdocument<InferId<T>> & T> { | |||
| /** DocumentArray constructor */ | |||
| constructor(values: any[]); | |||
| constructor(values: (T & AnyObject)[]); | |||
There was a problem hiding this comment.
AnyObject is realistically the best we can do here.
There was a problem hiding this comment.
On second thought, for consistency with push, let's do AnyKeys<T> & AnyObject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
DocumentArrayconstructor parameter type fromany[]to(T & AnyObject)[].closes #13087