Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): propagate typeKey down to implicitly created subdocuments #13164

Merged
merged 1 commit into from Mar 14, 2023
Merged

fix(schema): propagate typeKey down to implicitly created subdocuments #13164

merged 1 commit into from Mar 14, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13154

Summary

There's a bug that prevents using typeKey with implicitly created subdocuments. See test case for an example. Looks like we missed a spot where we aren't passing typeKey down in Schema.prototype.add().

Examples

@vkarpov15 vkarpov15 merged commit 2fedff1 into master Mar 14, 2023
@AbdelrahmanHafez AbdelrahmanHafez deleted the vkarpov15/gh-13154 branch March 14, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create a schema with a subdocument containing the key "type"
2 participants
@vkarpov15 @hasezoey