Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove deprecations guide, no longer relevant in Mongoose 7 #13567

Closed
wants to merge 1 commit into from

Conversation

vkarpov15
Copy link
Collaborator

Summary

This guide is no longer relevant in Mongoose 7 as was mentioned in #13547

Examples

@vkarpov15 vkarpov15 requested a review from hasezoey July 2, 2023 21:44
@hasezoey
Copy link
Collaborator

hasezoey commented Jul 2, 2023

if it is just currently not relevant anymore, how about repurposing it as a general deprecation notice instead of just mongodb driver deprecations? (a replacement to the wiki, which seems to not be actively used anymore)

and while there is nothing to list just say that there is nothing to list (yet)?

@vkarpov15
Copy link
Collaborator Author

Given that there's nothing to list right now, I think we should err on the side of removing this page. We can always add it back once we have something to list.

2 similar comments
@vkarpov15

This comment was marked as duplicate.

@vkarpov15

This comment was marked as duplicate.

@hasezoey
Copy link
Collaborator

hasezoey commented Jul 3, 2023

Given that there's nothing to list right now, I think we should err on the side of removing this page. We can always add it back once we have something to list.

also sounds good to me

PS: i have hidden the duplicate messages that seem to be there by accident

Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasezoey
Copy link
Collaborator

hasezoey commented Jul 6, 2023

i actually think now that #13572 has been merged, there is a reason to still have the deprecation file, mentioning that findOneAndUpdate option overwrite is deprecated and findOneAndReplace should be used instead

@vkarpov15
Copy link
Collaborator Author

Good point @hasezoey , I'll close this and create a new PR to remove the contents of the current deprecation guide and instead add the overwrite deprecation there once we have that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants