Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): support 'ascending', 'asc', 'descending', 'desc' for index direction #13761

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13725

Summary

Our TypeScript types say Mongoose supports 'ascending' and 'descending' as IndexDirection, but runtime behavior doesn't support that. I figure it is easy enough to add support to runtime behavior rather than removing the TypeScript types.

Examples

@vkarpov15 vkarpov15 added this to the 7.4.4 milestone Aug 22, 2023
@vkarpov15 vkarpov15 merged commit 5fdb89c into master Aug 22, 2023
37 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13725 branch August 22, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index not created when using ascending or descending
2 participants