BREAKING CHANGE: make Model.validate()
use Model.castObject()
to cast, and return casted copy of object instead of modifying in place
#13827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12668
Summary
Model.validate()
currently modifies the passed in object for casting purposes, which is inconsistent with howModel.castObject()
works and can leave the passed-in object in a half-casted state if there's a cast error. This PR makesModel.validate()
useModel.castObject()
to create a casted copy ofobj
, and run validation on all paths that successfully casted.Examples