Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(populate): avoid match function filtering out null values in populate result #14518

Merged
merged 1 commit into from Apr 11, 2024
Merged

fix(populate): avoid match function filtering out null values in populate result #14518

merged 1 commit into from Apr 11, 2024
+55 −2

Conversation

vkarpov15
Copy link
Collaborator

Fix #14494

Summary

If there's a match function, sift will always filter out null results, so we may populate docs in incorrect order.

Examples

@vkarpov15 vkarpov15 merged commit 2d4cbb8 into master Apr 11, 2024
34 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14494 branch April 11, 2024 15:25
@vkarpov15 vkarpov15 added this to the 7.6.11 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.6.11
Development

Successfully merging this pull request may close these issues.

Unexpected population of virtual with match() function in an embedded subdocument array
2 participants
@vkarpov15 @hasezoey