fix(query): shallow clone $or, $and if merging onto empty query filter #14580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14567
Summary
Currently, when you call
TestModel.find({ $and })
, Mongoose doesn't clone the$and
. ThenQuery.prototype.and()
usespush()
to add onto the$and
array, which modifies the existing$and
array.We already have some logic in place from #12944 that shallow clones $and, $or if they're set, but that only currently kicks in if there's an existing
$and
/$or
. With this PR, we'll do a shallow clone on$and
,$or
if they exist on the user's provided query filter.Examples