Bug fix: Model#save should pass numberAffected as 0 when nothing changed #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burtonjc
changed the title
|
Thanks! |
fixed; undefined callback in aggregate
|
@vkarpov15 I was fixing merge conflicts for this PR and somehow closed it, sorry about that. Reopening. |
vkarpov15
added a commit
that referenced
this pull request
Jul 26, 2015
Bug fix: Model#save should pass numberAffected as 0 when nothing changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, calling
Model#saveon an unchanged document results innumberAffectedin the callback being set to the document itself. According to the docs,numberAffectedshould always be0or1(never a document):In mongoose v3.x this used to work as expected, it was only after upgrading to v4 that we noticed this.