New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openUri() and useMongooseUri option, deprecate open() and openSet() #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobafuchs
reviewed
Jun 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, should we change the connection logic in the tests to use useMongooseUri
or should we just allow those errors to clutter up the test output?
Good suggestions, thanks. Will use |
MadLittleMods
added a commit
to gitterHQ/mongoose
that referenced
this pull request
Dec 31, 2022
MadLittleMods
added a commit
to gitterHQ/mongoose
that referenced
this pull request
Dec 31, 2022
Backport `useMongoClient` option to `4.6.8` Originally introduced in: Automattic#5355 Then updated with latest changes from `4.13.21`: - https://github.com/Automattic/mongoose/blame/4.13.21/lib/connection.js - https://github.com/Automattic/mongoose/blame/4.13.21/lib/index.js - https://github.com/Automattic/mongoose/blame/4.13.21/test/connection.test.js - https://github.com/Automattic/mongoose/blob/4.13.21/test/common.js New tests passing: ```sh $ npm run mocha -- test/connection.test.js [...] 71 passing (15s) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5304
Mongoose's default connection logic is deprecated by this PR. Please opt in to the new connection logic using the
useMongoClient
option (or useopenUri()
if you're usingopen()
oropenSet()
), but make sure you test your connections first if you're upgrading an existing codebase!This deprecation is because the MongoDB driver has deprecated an API that is critical to mongoose's connection logic to support MongoDB 3.6, see #5304 for details.