Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openUri() and useMongooseUri option, deprecate open() and openSet() #5355

Merged
merged 7 commits into from Jun 24, 2017

Conversation

vkarpov15
Copy link
Collaborator

@vkarpov15 vkarpov15 commented Jun 13, 2017

#5304

Mongoose's default connection logic is deprecated by this PR. Please opt in to the new connection logic using the useMongoClient option (or use openUri() if you're using open() or openSet()), but make sure you test your connections first if you're upgrading an existing codebase!

    // Using `mongoose.connect`...
    var promise = mongoose.connect('mongodb://localhost/myapp', { useMongoClient: true, /* other options */ });
    // Or `createConnection`
    var promise = mongoose.createConnection('mongodb://localhost/myapp', { useMongoClient: true, /* other options */ });
    // Or, if you already have a connection
    connection.openUri('mongodb://localhost/myapp', { /* options */ });

This deprecation is because the MongoDB driver has deprecated an API that is critical to mongoose's connection logic to support MongoDB 3.6, see #5304 for details.

@vkarpov15 vkarpov15 self-assigned this Jun 13, 2017
@vkarpov15 vkarpov15 requested a review from sobafuchs June 13, 2017 17:49
Copy link
Contributor

@sobafuchs sobafuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should we change the connection logic in the tests to use useMongooseUri or should we just allow those errors to clutter up the test output?

@vkarpov15
Copy link
Collaborator Author

Good suggestions, thanks. Will use useMongoClient instead.

@vkarpov15 vkarpov15 merged commit 5e4d0e6 into 4.11 Jun 24, 2017
@vkarpov15 vkarpov15 deleted the 5304 branch June 24, 2017 01:52
MadLittleMods added a commit to gitterHQ/mongoose that referenced this pull request Dec 31, 2022
MadLittleMods added a commit to gitterHQ/mongoose that referenced this pull request Dec 31, 2022
Backport `useMongoClient` option to `4.6.8`

Originally introduced in: Automattic#5355

Then updated with latest changes from `4.13.21`:

 - https://github.com/Automattic/mongoose/blame/4.13.21/lib/connection.js
 - https://github.com/Automattic/mongoose/blame/4.13.21/lib/index.js
 - https://github.com/Automattic/mongoose/blame/4.13.21/test/connection.test.js
 - https://github.com/Automattic/mongoose/blob/4.13.21/test/common.js


New tests passing:
```sh
$ npm run mocha -- test/connection.test.js
[...]
71 passing (15s)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants