Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of bson dependency to match mongodb-core #7213

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

NewEraCracker
Copy link
Contributor

Summary

Bump version of bson dependency from ~1.0.5 (npm installs 1.0.9) to ~1.1.0 (npm installs 1.1.0).

mongodb-core 3.1.7 has it's dependency set to bson 1.1.0 (^1.1.0)

Test plan

Differences between bson 1.0.5 and bson 1.1.0:
mongodb/js-bson@0ea96bd...39215f0

Differences between bson 1.0.9 and bson 1.1.0:
mongodb/js-bson@7656804...39215f0

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks 👍

@vkarpov15 vkarpov15 added this to the 5.3.9 milestone Nov 2, 2018
@vkarpov15 vkarpov15 merged commit 40d4177 into Automattic:master Nov 2, 2018
@vkarpov15
Copy link
Collaborator

@lineus worth making a note of this. I forgot to check that the bson dep matches the mongodb-core dep when we bumped :(

@lineus
Copy link
Collaborator

lineus commented Nov 2, 2018

I'll remember that for next time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants