Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
perf(documentarray): refactor to use ES6 classes instead of mixins, 30% speedup #8037
Should be fine to release in 5.6.8, but I want to see if we can make this a little bit faster, because this is still slightly slower than Mongoose 4.13
It looks like I managed to fix the tests by removing event emitter registration in the doc array constructor - it isn't strictly necessary because we can just set
This looks great! I found something kind of funny running our test suite against it that I thought I'd alert you to. I'm not sure if you'd consider it to be a bug in
If you run this script on 336e995 (with node 10 and 12, at least), you'll get infinite recursion in
That may be something you'd expect consumers to work around, but I thought it was worth calling out.