Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: proof of concept for using proxies to track changes on arrays #9290

Merged
merged 26 commits into from
Feb 15, 2021
Merged

feat: proof of concept for using proxies to track changes on arrays #9290

merged 26 commits into from
Feb 15, 2021

Conversation

vkarpov15
Copy link
Collaborator

Work in progress for fixing #8884 . This particular PR solves the issue with arr[0] = 42 not triggering change tracking on arr. Still needs work to remove the CoreMongooseArray concept so we can compare Mongoose arrays to real arrays using assert.deepStrictEqual().

@vkarpov15 vkarpov15 mentioned this pull request Aug 31, 2020
Closed
@vkarpov15
Merge branch '6.0' into gh-8884
2eb9f7f
@vkarpov15
fix: clean up test failures on #8884 branch
fc58adb
@vkarpov15
perf(array): improve perf on #9588 benchmark by 50% with #8884 proxy …
f728783 
…changes
@vkarpov15
test(array): add some test coverage for #8884
1ec2cc0
@vkarpov15
Merge branch '6.0' into gh-8884
b519993
@vkarpov15
fix(array): correct inspect output for array proxies in Node.js 14 re: …
4caea65 
…#8884
@vkarpov15
BREAKING CHANGE: drop support for Node.js < 10
6a4f9e0
@vkarpov15
chore: wip
b30ffd1
@vkarpov15
Merge branch '6.0' into gh-8884
0c2aa3e
@vkarpov15
feat(types): make document arrays into proxies
856f39c 
Re: #8884
@vkarpov15
fix: correctly handle updating document arrays internally
ff1b6a6
@vkarpov15
test: test cleanup re: #8884
39b1c50
@vkarpov15
fix: correct proxy-based change tracking with addToSet() re: #8884
a8e2c18
@vkarpov15
refactor: start moving symbols out of raw arrays
f08b9a5
@vkarpov15
Merge branch '6.0' into gh-8884
0fd5621
@vkarpov15
fix: remove atomics from core array, move into internals object
e1fb40b 
Re: #8884
@vkarpov15
refactor: move array to separate directory re: #8884
54b265c
@vkarpov15
refactor(types): remove documentArrayProxy(), make MongooseDocumentAr…
49c9735 
…ray return a proxy re: #8884
@vkarpov15
refactor: start removing CoreMongooseArray class re: #8884
006ed2b
@vkarpov15
refactor: move DocumentArray methods to separate directory re: #8884
1570da6
@vkarpov15
perf: shave 15% off of array proxy performance re: #8884
6a4a638
@vkarpov15
perf: some more performance improvements for primitive array proxies …
5f8e8a0 
…re: #8884
@vkarpov15
test: fix a couple of tests re: #8884
1d8b00f
@vkarpov15
test: make versioning test less brittle
0953ff5
@vkarpov15 vkarpov15 merged commit 127567d into 6.0 Feb 15, 2021
@Uzlopak Uzlopak deleted the gh-8884 branch June 14, 2022 15:11
@yelworc yelworc mentioned this pull request Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vkarpov15