Gh 9374 from 6.0 #9941
Merged
Gh 9374 from 6.0 #9941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested changes
Feb 17, 2021
Rossh87
force-pushed
the
gh-9374_from-6.0
branch
from
ae4ffe0
to
5fb155e
Compare
…ry connections MongoDB will not allow index creation on a non-primary replica. If user-specified connection explicitly sets index creation options, and specifies secondary read preference, throw. Otherwise, default index options to false.
Rossh87
force-pushed
the
gh-9374_from-6.0
branch
from
5fb155e
to
acfb6f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements sensible defaults discussed in #9374 if connection readPreference is 'secondary' or 'preferSecondary'. If readPreference will be set to 'nearest' or 'primaryPreferred', it warns but otherwise behaves as before.
Examples
Several tests added for Mongoose.prototype.connect and Mongoose.prototype.createConnection.