Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure image scale CSS class is applied in editor #1717

Merged
merged 1 commit into from Apr 24, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Similar to #1706, this PR fixes an issue where the image scale S wasn't previewing in the editor.

I think both of these were kind of introduced here, but I can't, for the life of me, remember why those two sizes were excluded from the classes to begin with.

How to test the changes in this Pull Request:

  1. Add a HPB to the editor, and align the images left or right.
  2. Change the image size using the option in the sidebar, from L to XL, M, then S. Note that M and S are the same.
  3. Apply this PR and run npm run build.
  4. Rerun step 2 and confirm that S now previews correctly (should be ~25% of the available space).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford
Copy link
Contributor Author

Thanks @dkoo!

@laurelfulford laurelfulford merged commit 1f5c3e2 into release Apr 24, 2024
9 checks passed
@laurelfulford laurelfulford deleted the hotfix/editor-image-size-class branch April 24, 2024 20:45
matticbot pushed a commit that referenced this pull request Apr 24, 2024
## [3.0.10](v3.0.9...v3.0.10) (2024-04-24)

### Bug Fixes

* make sure image scale CSS class is applied in editor ([#1717](#1717)) ([1f5c3e2](1f5c3e2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-epic-ras-acc.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants