-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logic func which will throw exception if core WP tables are empty. #330
Open
eddiesshop
wants to merge
11
commits into
trunk
Choose a base branch
from
feat/check-for-empty-core-wp-tables-content-diff
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: logic func which will throw exception if core WP tables are empty. #330
eddiesshop
wants to merge
11
commits into
trunk
from
feat/check-for-empty-core-wp-tables-content-diff
+127
−7
Commits on Aug 17, 2023
-
feat: logic func which will throw exception if core WP tables are empty.
During a recent content diff, somehow the live wp_terms table (the table with new content that we're trying to merge into the current database) was empty. This caused the function recreate_categories to not function as expected. This is because when it tries to gather all the categories which must be brought over, it does a JOIN with this wp_terms table. But if that table is empty, the query will return no results, even though the wp_terms_taxonomy table has valid categories to be imported. This function attempts to prevent that from happening in the first place, by checking if any core WP tables are empty before proceeding in earnest with the content diff.
Configuration menu - View commit details
-
Copy full SHA for b039208 - Browse repository at this point
Copy the full SHA b039208View commit details -
feat: created CoreWPTableEmptyException class to allow for better con…
…ditional handling of which Core WP tables can be safely ignored.
Configuration menu - View commit details
-
Copy full SHA for bb99a37 - Browse repository at this point
Copy the full SHA bb99a37View commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ac14ded - Browse repository at this point
Copy the full SHA ac14dedView commit details -
feat: ignoring a few more tables by default for content diff.
Adding wp_termmeta, wp_comments, and wp_commentmeta to list of default ignored tables.
Configuration menu - View commit details
-
Copy full SHA for c180170 - Browse repository at this point
Copy the full SHA c180170View commit details
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 312b3f0 - Browse repository at this point
Copy the full SHA 312b3f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4c7d32 - Browse repository at this point
Copy the full SHA f4c7d32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73e56bd - Browse repository at this point
Copy the full SHA 73e56bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c883de - Browse repository at this point
Copy the full SHA 9c883deView commit details -
Configuration menu - View commit details
-
Copy full SHA for abe6ac4 - Browse repository at this point
Copy the full SHA abe6ac4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91d8abc - Browse repository at this point
Copy the full SHA 91d8abcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eed2e9 - Browse repository at this point
Copy the full SHA 8eed2e9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.