Support: send initial info on chat start #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
added
the
[Status] Needs Review
claudiulodro
requested changes
Mar 6, 2020
There was a problem hiding this comment.
With master branch the chat works, but on this branch I get some sort of infinite loop from the happychat-client library crashing the chat (Uncaught RangeError: Maximum call stack size exceeded).
As best I can tell from going through the stack trace, the Happychat.sendUserInfo call here is triggering the 'availability' event, resulting in an infinite loop. Moving didSendInitialInfo = true; to line 56 (above Happychat.sendUserInfo) solves the issue.
claudiulodro
added
[Status] Needs changes or feedback
claudiulodro
reviewed
Mar 6, 2020
| let didSendInitialInfo; | ||
| Happychat.on( 'availability', availability => { | ||
| if ( ! didSendInitialInfo && availability ) { | ||
| Happychat.sendUserInfo( { |
There was a problem hiding this comment.
Suggested change
| Happychat.sendUserInfo( { | |
| didSendInitialInfo = true; | |
| Happychat.sendUserInfo( { |
This change will prevent an infinite loop without otherwise affecting the behavior.
adekbadek
added
[Status] Needs Review
claudiulodro
approved these changes
Mar 9, 2020
claudiulodro
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Mar 10, 2020
# [1.1.0](v1.0.0...v1.1.0) (2020-03-10) ### Bug Fixes * fix Site Kit module deactivation ([96787e9](96787e9)) * standardize REST API namespace usage ([44d15b2](44d15b2)) ### Features * **support:** add a link to support docs ([#470](#470)) ([af4754d](af4754d)) * **support:** send initial info on chat start ([#471](#471)) ([1392452](1392452)) * **support:** update subject string for support tickets ([aca9963](aca9963))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In order for HEs to know that they're dealing with a Newspack customer, an "event" will be sent at the beginning of the chat. Events are used for messages like "user is navigating to billing page", but here we'll use this feature to "mark" a Newspack customer.
Also, the "user info" is added here for convenience. It has a link to the site, as well as some browser information.
How to test the changes in this Pull Request:
[ Newspack customer ]message are prepended.Other information: