Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sync country code of WooCommerce order to Salesforce contact #608

Merged
merged 1 commit into from Aug 3, 2020
Merged

feat: sync country code of WooCommerce order to Salesforce contact #608

merged 1 commit into from Aug 3, 2020

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jul 29, 2020 •
edited

Passes along the 'country' property to the Salesforce contact. Also some minor refactoring to clean up some deeply nested vars.

All Submissions:

Changes proposed in this Pull Request:

Passes the country property from the WooCommerce order data to the Salesforce Contact data. Also some minor refactoring to clean up some deeply nested array vars.

Closes #607.

How to test the changes in this Pull Request:

  1. Ensure that Salesforce is connected and Contact/Opportunity syncing is active.
  2. Make a donation from the Donation block. In the checkout page, set the country to something other than United States, for ease of testing. (I selected United Kingdom and entered PO1-3AX as a valid UK postcode).
  3. In Salesforce, look up the contact by the email address you used for the transaction.
  4. In the Details tab, under Mailing Address, note the country code. It should match the country you selected in the checkout page.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo
feat: sync country code of WooCommerce order to Salesforce
716b87c 
Passes along the 'country' property to the Salesforce contact. Also some minor refactoring to clean up some deeply nested vars.
@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 29, 2020
@dkoo dkoo requested a review from jeffersonrabb July 29, 2020 16:25
adekbadek
adekbadek approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 3, 2020
@dkoo dkoo merged commit c92c5d8 into master Aug 3, 2020
@dkoo dkoo deleted the add/salesforce-country-info branch August 3, 2020 19:49
matticbot pushed a commit that referenced this pull request Aug 4, 2020
@semantic-release-bot
chore(release): 1.16.0 [skip ci]
93ec102 
# [1.16.0](v1.15.0...v1.16.0) (2020-08-04)

### Bug Fixes

* dont output uninstalled managed plugins in WP CLI ([66a050e](66a050e))
* empty space in three-column wizard grid ([#612](#612)) ([61ef44a](61ef44a))
* site kit connection error handling ([#606](#606)) ([13ad3ae](13ad3ae))

### Features

* sync country code of WooCommerce order to Salesforce ([#608](#608)) ([c92c5d8](c92c5d8))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

@jeffersonrabb jeffersonrabb Awaiting requested review from jeffersonrabb

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Salesforce: Customer Country?
3 participants
@dkoo @matticbot @adekbadek