Skip to content

Commit

Permalink
Fixes #182
Browse files Browse the repository at this point in the history
  • Loading branch information
lpinca committed Aug 8, 2012
1 parent 5a5a8e3 commit 0204157
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/closure.h
Expand Up @@ -16,7 +16,7 @@ typedef struct {
Persistent<Function> pfn;
Handle<Function> fn;
unsigned len;
unsigned max_len;
int16_t max_len;
uint8_t *data;
Canvas *canvas;
cairo_status_t status;
Expand Down

1 comment on commit 0204157

@c-spencer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change?

And why such a small integer? This is causing segfaults with pdf rendering as the max_len overflows (pdfs are streamed into memory as they are created using toBuffer)

(Seemingly something to do with v8::AdjustAmountOfExternalAllocatedMemory, but that takes an intptr_t)

Please sign in to comment.