Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixes #182

  • Loading branch information...
commit 02041571cec76696adf30c3e5f55cdb13e144d20 1 parent 5a5a8e3
@lpinca lpinca authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/closure.h
View
2  src/closure.h
@@ -16,7 +16,7 @@ typedef struct {
Persistent<Function> pfn;
Handle<Function> fn;
unsigned len;
- unsigned max_len;
+ int16_t max_len;
uint8_t *data;
Canvas *canvas;
cairo_status_t status;

1 comment on commit 0204157

@c-spencer

I don't understand this change?

And why such a small integer? This is causing segfaults with pdf rendering as the max_len overflows (pdfs are streamed into memory as they are created using toBuffer)

(Seemingly something to do with v8::AdjustAmountOfExternalAllocatedMemory, but that takes an intptr_t)

Please sign in to comment.
Something went wrong with that request. Please try again.