Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for valid jpeg EOI marker #1034

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Add unit test for valid jpeg EOI marker #1034

merged 1 commit into from
Nov 15, 2017

Conversation

binarykitchen
Copy link
Contributor

No description provided.

@binarykitchen binarykitchen mentioned this pull request Nov 13, 2017
Closed
zbjornson
zbjornson approved these changes Nov 13, 2017
View reviewed changes
Copy link
Collaborator

@zbjornson zbjornson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! (leaving open for ~24 hrs to give others the chance to review)

@LinusU
Copy link
Collaborator

LinusU commented Nov 14, 2017

Could you not add the yarn.lock file? Not everyone is using yarn so it will quickly get out of date... It's also not as important in a library as in an app...

@binarykitchen
Copy link
Contributor Author

@LinusU done, removed

@LinusU
Copy link
Collaborator

LinusU commented Nov 15, 2017

Awesome, thanks you!

@LinusU LinusU merged commit 7f1be7b into Automattic:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbjornson zbjornson zbjornson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@binarykitchen @LinusU @zbjornson