Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define correct isnan, isinf functions #522

Merged
merged 2 commits into from Feb 20, 2015
Merged

Conversation

janza
Copy link
Contributor

@janza janza commented Feb 12, 2015

fixes #520

@janza
Copy link
Contributor Author

janza commented Feb 13, 2015

This PR fixes building node-canvas on linux with io.js. I've also added travis io.js target to confirm that it's working.

@kangax
Copy link
Collaborator

kangax commented Feb 19, 2015

/cc @woodcoder @TooTallNate @rvagg

@rvagg
Copy link
Contributor

rvagg commented Feb 19, 2015

Using an io.js branch of dnt:

~/git/node-canvas $ dnt
node@v0.11.16: PASS wrote output to /tmp/canvas-dnt-v0.11.16.out
node@v0.10.36: PASS wrote output to /tmp/canvas-dnt-v0.10.36.out
node@v0.12.0 : PASS wrote output to /tmp/canvas-dnt-v0.12.0.out
iojs@v1.1.0  : FAIL wrote output to /tmp/canvas-dnt-v1.1.0.out
iojs@v1.0.0  : FAIL wrote output to /tmp/canvas-dnt-v1.0.0.out
iojs@v1.2.0  : FAIL wrote output to /tmp/canvas-dnt-v1.2.0.out
Took 462s to run 6 versions of Node
[rvagg@fletcher (master) ~/git/node-canvas]$ curl https://github.com/Automattic/node-canvas/pull/522.patch | git am
Applying: define correct isnan, isinf functions
Applying: run travis tests against io.js
~/git/node-canvas $ dnt
node@v0.10.36: PASS wrote output to /tmp/canvas-dnt-v0.10.36.out
node@v0.11.16: PASS wrote output to /tmp/canvas-dnt-v0.11.16.out
node@v0.12.0 : PASS wrote output to /tmp/canvas-dnt-v0.12.0.out
iojs@v1.1.0  : PASS wrote output to /tmp/canvas-dnt-v1.1.0.out
iojs@v1.0.0  : PASS wrote output to /tmp/canvas-dnt-v1.0.0.out
iojs@v1.2.0  : PASS wrote output to /tmp/canvas-dnt-v1.2.0.out
Took 493s to run 6 versions of Node

so 👍 from me!

@jomo
Copy link

jomo commented Feb 20, 2015

Pulled and tested (dokku & travis), issue indeed fixed.
👍 from me as well

kangax added a commit that referenced this pull request Feb 20, 2015
Define correct isnan, isinf functions
@kangax kangax merged commit eb8f50b into Automattic:master Feb 20, 2015
@kangax
Copy link
Collaborator

kangax commented Feb 20, 2015

Great, thanks everyone, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build with io.js on linux
4 participants