Profile bookmarks - Add search #2037
Conversation
|
|
||
| @OptIn(ExperimentalCoroutinesApi::class) | ||
| suspend fun getBookmarkSearchResultsFlow() = searchQueryFlow.flatMapLatest { searchTerm -> | ||
| if (searchTerm.isNotEmpty()) { |
There was a problem hiding this comment.
It would be useful to trim() the searchTerm so things like My bookmark work.
There was a problem hiding this comment.
Yes, here you go: a115ab3
| id = if (state.bookmarks.size > 1) { | ||
| LR.string.bookmarks_plural | ||
| } else { | ||
| LR.string.bookmarks_singular |
There was a problem hiding this comment.
I realize this is already in our app but shouldn't this be handles with plural strings and not regular strings? Otherwise it doesn't translate well to different languages that have different grammar rules for different quantities.
There was a problem hiding this comment.
I don't know the full context but it could be due to GlotPress not supporting plurals yet. I'll leave it for now and we can discuss it internally.
ashiagr
force-pushed
the
task/profile-bookmarks-part4
branch
from
a115ab3
to
afa6e29
Compare
|
When sorting by Podcast & Episode, custom files don't get split up for each file, so all of them are just sorted by timestamp, jumbled together. Don't really have time to open an Issue right now, so just commenting here. |
Description
This adds search to the profile bookmarks screen.
Testing Instructions
Screenshots or Screencast
search.mp4
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...