Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #2286 in order to avoid Search Term gets cleared when scrolled off-screen issue #2353

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Jun 14, 2024

Description

Fixes #2352

Testing Instructions

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mebarbosa mebarbosa added the bug Something isn't working label Jun 14, 2024
@mebarbosa mebarbosa added this to the 7.66 ❄️ milestone Jun 14, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner June 14, 2024 16:30
@mebarbosa mebarbosa requested review from ashiagr and removed request for a team June 14, 2024 16:30
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 7.66 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@mebarbosa mebarbosa linked an issue Jun 14, 2024 that may be closed by this pull request
1 task
@ashiagr ashiagr merged commit cfa0d5d into release/7.66 Jun 17, 2024
14 of 15 checks passed
@ashiagr ashiagr deleted the revert/pr-2286 branch June 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Term gets cleared when scrolled off-screen
3 participants