Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow select text in show notes from episode details view. #372

Merged
merged 2 commits into from Oct 6, 2022
Merged

Allow select text in show notes from episode details view. #372

merged 2 commits into from Oct 6, 2022

Conversation

geekygecko
Copy link
Member

This change allows the user to select text from the show notes on the full-screen episode details view.

Thanks to @karacca for looking into this issue.

Fixes #143

Test steps

  1. Tap on the "Podcasts" tab
  2. Tap on a podcast
  3. Tap on an episode
  4. Long press on the show notes to select text

You should be allowed to copy text from the show notes.

@geekygecko geekygecko marked this pull request as ready for review October 5, 2022 20:26
@geekygecko geekygecko requested a review from a team as a code owner October 5, 2022 20:26
@geekygecko geekygecko mentioned this pull request Oct 5, 2022
Closed
ashiagr
ashiagr approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, @geekygecko, @karacca 🙌

:shipit:

@ashiagr ashiagr merged commit b52827b into main Oct 6, 2022
@ashiagr ashiagr deleted the update/show-notes-select branch October 6, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Select Text in Show Notes From Episode Details View
2 participants
@geekygecko @ashiagr