Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new episode lists to Automotive OS. Starred, Listening History, and Files. #403

Merged
merged 2 commits into from Oct 13, 2022

Conversation

geekygecko
Copy link
Member

This change adds a new section Profile section to Android Automotive. The section includes the profile episode lists of Starred and Listening History. If the user is signed into Plus then they also see Files, the user uploaded files.

Having four tabs doesn't look great in some of the emulators but it seems fine in the Polestar emulator. It makes more sense to match the mobile apps and have the lists in a Profile section, rather than put the lists in the Filters section. The Filters section should be left for just subscribed podcasts or it may cause confusion for the user.

Fixes #348

To test

Profile episode lists

  1. Tap the Discover tab
  2. Tap a podcast
  3. Tap an episode
  4. In the full screen player tap the three dots next to the skip forward button.
  5. Tap the star icon
  6. Close the full screen page and podcast page
  7. Tap the Profile tab
  8. Tap the Starred item
  9. ✅ Verify you see the episode you starred in the list
  10. Tap the back arrow
  11. Tap the Listening History item
  12. ✅ Verify you see the episode you played in the list

Files episode list

  1. Tap the settings cog
  2. Sign into a Pocket Casts account with Plus
  3. Tap the Podcasts tab
  4. Tap the Filters tab
  5. ✅ Verify you see the Files item in the list

@geekygecko geekygecko marked this pull request as ready for review October 13, 2022 01:16
@geekygecko geekygecko requested a review from a team as a code owner October 13, 2022 01:16
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @geekygecko! I tested Profile options and found everything working. I agree with your decision to keep these new options under Profile to be consistent with the mobile version and to avoid confusion.

Code changes look good too 👍

@ashiagr ashiagr merged commit 481e5eb into main Oct 13, 2022
@ashiagr ashiagr deleted the update/automotive-profile-lists branch October 13, 2022 06:51
@ashiagr ashiagr added this to the 7.25 milestone Oct 13, 2022
@ashiagr ashiagr added the automotive Issues relating the automotive app running directly in a head unit label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automotive Issues relating the automotive app running directly in a head unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Automotive: Starred episode list
2 participants