Discover sorts categories alphabetically

[jamie23]

Description

Fixing an issue where the category list inside discover is sorted based on the english strings. If a user has their device in a different language then the list is not sorted alphabetically.

Fixes #673

Testing Instructions

1. Fresh install of the app.
2. Start the app.
3. Navigate to the discover page with system settings in English.
4. Notice that the categories listed under "Browse By Category" are sorted alphabetically.
5. Set your system language to another language e.g. French.
6. Navigate to the discover page.
7. Notice that the categories listed under "Bowser By Category" are still sorted alphabetically.

Screenshots or Screencast

Checklist

• If this is a user-facing change, I have added an entry in CHANGELOG.md
• I have considered whether it makes sense to add tests for my changes

I have tested any UI changes...

• with different themes
• with a landscape orientation
• with the device set to have a large display and font size
• for accessibility with TalkBack

[CLAassistant]

All committers have signed the CLA.

[jamie23]

Can you let me know if you want me to update the CHANGELOG.md file? It's my first contribution to the project so I wasn't sure if small fixes like this were necessary to note in that file.

Also, I tried to keep the changes as minimal as possible since it is my first contribution. By sorting based on the translation before passing to the adapter we still do another translation on the other side inside CategoriesListRowAdapter, we could get rid of the double translation by mapping the categories to a translated version before sorting, and passing this into the adapter. e.g.

DiscoverAdapter.kt:

onSuccess = { categories ->
    val sortedCategories = categories.map { it.copy(name = it.name.tryToLocalise(resources)) }.sortedBy { it.name }
    
    adapter.submitList(sortedCategories) {
        onRestoreInstanceState(holder)
    }
}

CategoriesListRowAdapter.kt:

override fun onBindViewHolder(holder: CategoryViewHolder, position: Int) {
    val category = getItem(position)
    holder.binding.lblTitle.text = category.name
    holder.binding.imageView.load(category.icon)
    holder.itemView.setOnClickListener { onPodcastListClick(category) }
}

If you prefer this, let me know and I can make the updates.

[ashiagr]

Hey @jamie23 👋

I tried to keep the changes as minimal as possible since it is my first contribution. By sorting based on the translation before passing to the adapter we still do another translation on the other side inside CategoriesListRowAdapter, we could get rid of the double translation by mapping the categories to a translated version before sorting, and passing this into the adapter.

Could you please go ahead and make this change to prevent double translation? It's your first contribution but you're spot on! 💪

Can you let me know if you want me to update the CHANGELOG.md file? It's my first contribution to the project so I wasn't sure if small fixes like this were necessary to note in that file.

Yes, please. Go ahead and add it to the change log as it is a user-facing change and it's good to highlight it.

Thank you! 🙇

[jamie23]

Thanks @ashiagr , I've made the changes both to the code and CHANGELOG.md, if there is anything else please let me know.

[ashiagr]

Looks great, thank you!