Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on season grouping #962

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 15, 2023

Description

This fixes crash on grouping by season for certain podcasts (e.g. https://pca.st/9NOf)

Fixes #961

Testing Instructions

  1. Subscribe to https://pca.st/9NOf
  2. Go to Pocket Casts > Profile > Settings > General > Podcast Episode Grouping, set it to None
  3. View the podcast page
  4. Now go back to Podcast Episode Grouping and set it to 'Season'
  5. Recheck the podcast page, you should not see any crash
  6. Scroll to the bottom
  7. You should see a "No season" group with an episode

Screenshots or Screencast

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner May 15, 2023 11:57
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this! 🙇

@mchowning mchowning merged commit 1e9b537 into main May 15, 2023
8 checks passed
@mchowning mchowning deleted the fix/961-episode-grouping-by-season branch May 15, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Loading Podcast Page when episode grouping by season is used
2 participants