Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the Automotive buffering and seeking #977

Merged
merged 4 commits into from
May 18, 2023
Merged

Conversation

geekygecko
Copy link
Member

Description

With Automotive, we are getting reports of issues with the seeking not working, buffering issues and out-of-memory crashes. A fix for this was to add the largeHeap configuration to the Automotive manifest file (already in the app manifest) and reduce the player buffer sizes. This is only with certain manufacturers so I have limited the buffer size for those.

Testing Instructions

  1. Deploy to Automotive
  2. ✅ Verify you can play an episode, seek to a new position, and use the skip buttons.

@geekygecko geekygecko marked this pull request as ready for review May 18, 2023 01:33
@geekygecko geekygecko requested a review from a team as a code owner May 18, 2023 01:33
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ashiagr ashiagr enabled auto-merge May 18, 2023 05:38
@ashiagr ashiagr merged commit bf7e4ee into main May 18, 2023
8 checks passed
@ashiagr ashiagr deleted the fix/automotive-oom branch May 18, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants