Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1389: Fall back to root VC if no topMostPresented is found #1653

Merged
merged 1 commit into from
May 2, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Apr 24, 2024

Fixes #1389

No topMostPresentedViewController is found when initially launching the app. We should fall back to the root view controller (the MainTabBarController) in these instances.

Before After

To test

  • Build and run on device

  • Kill the app

  • Add a link (https://pca.st/podcast/eebcc9f0-cec7-013c-5ce5-0acc26574db2) to reminders

  • Tap the link

  • Verify that the app displays the loading alert and opens to the podcast

  • Tap the link again while the app is backgrounded

  • Ensure that the podcast opens

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the Bug Something isn't working label Apr 24, 2024
@bjtitus bjtitus added this to the 7.63 milestone Apr 24, 2024
@bjtitus bjtitus requested a review from a team as a code owner April 24, 2024 21:43
@bjtitus bjtitus requested review from leandroalonso and removed request for a team April 24, 2024 21:43
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 24, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.63 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus changed the base branch from trunk to release/7.63 May 1, 2024 20:36
@bjtitus bjtitus merged commit ce33f75 into release/7.63 May 2, 2024
8 of 11 checks passed
@bjtitus bjtitus deleted the bjtitus/launch-url-handling branch May 2, 2024 00:25
@bjtitus bjtitus restored the bjtitus/launch-url-handling branch May 9, 2024 18:21
@bjtitus bjtitus deleted the bjtitus/launch-url-handling branch May 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a share link when the app is not running in the background doesn't open the shared item
3 participants