Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Library Update] Upgrade Firebase to 10.24.0 #1668

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Apr 29, 2024

Upgrades Firebase to 10.24.0.

In this version, they added XCFramework signing, although I'm not sure if it's actually needed since we've been passing App Store validation.

To test

There are two main things we need to test: events and remote feature flags. The app also uses Performance but we're looking into removing that so it's not part of the testing steps.

Remote Feature Flags

  1. Delete the app from your simulator/device
  2. Go to Constants.swift and change newPlayerTransitionDefault to false
  3. Run the app
  4. Go to Profile > Settings > Beta Features
  5. newPlayerTransition should be enabled, which means remote feature flags are working as expected

Events

  1. Go to AnalyticsHelper.swift and change private extension AnalyticsHelper to extension AnalyticsHelper
  2. On ProfileViewController.swift add AnalyticsHelper.logEvent("testing_testing") on the end of viewDidAppear
  3. Run the app
  4. Go to profile a few times
  5. Put the app on background
  6. ✅ Go to this link, change the date to today and check that the event has been triggered in the past 30 minutes (might take some time)

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the dependencies Pull requests that update a dependency file label Apr 29, 2024
@bjtitus bjtitus requested a review from a team as a code owner April 29, 2024 21:47
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team April 29, 2024 21:47
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 29, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.63 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus changed the title [Library Update] Upgrade firebase to 10.24.0 [Library Update] Upgrade Firebase to 10.24.0 Apr 29, 2024
@bjtitus bjtitus added this to the 7.63 milestone Apr 29, 2024
@leandroalonso leandroalonso changed the base branch from trunk to release/7.63 April 30, 2024 19:25
@bjtitus bjtitus merged commit 7a06ecf into release/7.63 Apr 30, 2024
8 of 10 checks passed
@bjtitus bjtitus deleted the bjtitus/dependencies/firebase branch April 30, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants