-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Change Avatar" button to account settings #1770
base: trunk
Are you sure you want to change the base?
Conversation
Pinar Olguc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Generated by 🚫 Danger |
Wouldn't it make more sence to just tap the icon? |
I think this is an experimental feature that's why, it's not a fully native experience to begin with. We just open a browser to change the avatar. But it's a fair question. cc @Luchadores and @david-gonzalez-a8c if you want to add anything. |
I think we can try it, not sure if there's any other trigger that Pocket Casts already has on the Avatar itself. If not, we can do it, and see if users tap more directly the Avatar itself. |
eec048c
to
7f05c4d
Compare
Fixes #
Adding the ability to change the avatar. Avatar is coming from user's Gravatar account. So the "Change Avatar" button opens the Gravatar web link via in-app Safari.
To test
Profile > Account > "Change Avatar"
Observe: In app Safari is presented
If you are not logged in to the app then "Change Avatar" button will not be present for you.
Checklist
CHANGELOG.md
if necessary.