Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt crash discovery #1968

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

danielebogo
Copy link
Contributor

This PR is an attempt to fix a crash introduced with #1604. The previous attempt #1756 didn't solve it.
This fix tries to decouple the intrinsicContentSize from the generic ThemeableTable by creating a new table used only in Discovery.

To test

As the previous attempt, I was unable to reproduce this issue. These are steps which I think may be causing the crash based on the stack traces:

Tap the Chromecast button from the player
Ensure that table is shown and app doesn't crash

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added the Bug Something isn't working label Jul 31, 2024
@danielebogo danielebogo added this to the 7.69 ❄️ milestone Jul 31, 2024
@danielebogo danielebogo marked this pull request as ready for review July 31, 2024 15:09
@danielebogo danielebogo requested a review from a team as a code owner July 31, 2024 15:09
@danielebogo danielebogo requested review from bjtitus and leandroalonso and removed request for a team and bjtitus July 31, 2024 15:09
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 7.69 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Member

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested removing the overriden methods and checking the categories (podcasts don't show)
✅ Tested by adding it back and it works as expected

@danielebogo danielebogo merged commit 648f583 into release/7.69 Jul 31, 2024
6 of 8 checks passed
@danielebogo danielebogo deleted the release/attempt-crash-discovery branch July 31, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working [Type] Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants