Skip to content

Commit

Permalink
WPML: Allow using of question categories in translated quizzes (#7559)
Browse files Browse the repository at this point in the history
  • Loading branch information
merkushin committed Apr 9, 2024
1 parent 7bba262 commit b13be20
Show file tree
Hide file tree
Showing 9 changed files with 218 additions and 77 deletions.
4 changes: 4 additions & 0 deletions changelog/fix-wpml-question-categories
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fix usage of question categories in translated quizzes
46 changes: 17 additions & 29 deletions config/psalm/psalm-baseline.xml
Expand Up @@ -1422,22 +1422,19 @@
<MissingDocblockType occurrences="1">
<code>public $token;</code>
</MissingDocblockType>
<MissingParamType occurrences="16">
<MissingParamType occurrences="13">
<code>$class</code>
<code>$classes</code>
<code>$course</code>
<code>$course_id</code>
<code>$course_id</code>
<code>$course_id</code>
<code>$course_id</code>
<code>$course_id</code>
<code>$excludes</code>
<code>$excludes</code>
<code>$message</code>
<code>$query</code>
<code>$query</code>
<code>$should_send</code>
<code>$user_id</code>
<code>$user_id</code>
</MissingParamType>
<MissingPropertyType occurrences="1">
Expand Down Expand Up @@ -1885,11 +1882,9 @@
<code>'WP_Post'</code>
<code>'WP_User'</code>
</ArgumentTypeCoercion>
<DocblockTypeContradiction occurrences="4">
<DocblockTypeContradiction occurrences="2">
<code>! isset( $lesson_id )</code>
<code>- 1 !== $new_course</code>
<code>-1</code>
<code>-1 !== $new_complexity</code>
</DocblockTypeContradiction>
<FalsableReturnStatement occurrences="2">
<code>empty( $block['innerBlocks'][0]['attrs']['id'] ) ? null : wp_get_attachment_url( get_post_thumbnail_id( $block['innerBlocks'][0]['attrs']['id'] ) )</code>
Expand Down Expand Up @@ -2080,12 +2075,10 @@
<code>is_array( $question_data )</code>
<code>is_countable( $questions_array )</code>
</RedundantCondition>
<RedundantConditionGivenDocblockType occurrences="9">
<RedundantConditionGivenDocblockType occurrences="7">
<code>! is_wp_error( $multiple_id )</code>
<code>$module_term</code>
<code>$module_term</code>
<code>- 1 !== $new_course</code>
<code>-1 !== $new_complexity</code>
<code>is_array( $data ) &amp;&amp; count( $data ) &gt; 0</code>
<code>is_array( $this-&gt;meta_fields )</code>
<code>isset( $this-&gt;meta_fields ) &amp;&amp; is_array( $this-&gt;meta_fields )</code>
Expand Down Expand Up @@ -2483,7 +2476,7 @@
<code>public static function gap_fill_load_question_data( $question_data, $question_id, $quiz_id ) {</code>
<code>public static function multiple_choice_load_question_data( $question_data, $question_id, $quiz_id ) {</code>
</InvalidDocblock>
<InvalidScalarArgument occurrences="29">
<InvalidScalarArgument occurrences="27">
<code>$id</code>
<code>$lesson_id</code>
<code>$lesson_id</code>
Expand All @@ -2501,8 +2494,6 @@
<code>$lesson_id</code>
<code>$lesson_id</code>
<code>$lesson_id</code>
<code>$lesson_id</code>
<code>$lesson_id</code>
<code>$question_id</code>
<code>$question_id</code>
<code>$question_id</code>
Expand Down Expand Up @@ -2726,9 +2717,6 @@
<code>! is_array( $new_value )</code>
<code>! is_array( $old_value )</code>
</DocblockTypeContradiction>
<DuplicateArrayKey occurrences="1">
<code>'type' =&gt; 'email'</code>
</DuplicateArrayKey>
<InvalidArgument occurrences="1"/>
<MissingParamType occurrences="3">
<code>$include_milliseconds</code>
Expand Down Expand Up @@ -4736,9 +4724,8 @@
</PossiblyInvalidPropertyFetch>
</file>
<file src="includes/internal/student-progress/quiz-progress/repositories/class-comments-based-quiz-progress-repository.php">
<InvalidScalarArgument occurrences="2">
<InvalidScalarArgument occurrences="1">
<code>$comment-&gt;comment_post_ID</code>
<code>$lesson_id</code>
</InvalidScalarArgument>
<PossiblyInvalidIterator occurrences="2">
<code>$comments</code>
Expand Down Expand Up @@ -5187,6 +5174,11 @@
<code>Sensei_REST_API_Import_Controller</code>
</PropertyNotSetInConstructor>
</file>
<file src="includes/rest-api/class-sensei-rest-api-internal.php">
<PossiblyNullArgument occurrences="1">
<code>Sensei()-&gt;tour</code>
</PossiblyNullArgument>
</file>
<file src="includes/rest-api/class-sensei-rest-api-lesson-quiz-controller.php">
<ArgumentTypeCoercion occurrences="1"/>
<DocblockTypeContradiction occurrences="1">
Expand Down Expand Up @@ -5422,6 +5414,11 @@
<code>Sensei_REST_API_Theme_Controller</code>
</PropertyNotSetInConstructor>
</file>
<file src="includes/rest-api/class-sensei-rest-api-tour-controller.php">
<PropertyNotSetInConstructor occurrences="1">
<code>Sensei_REST_API_Tour_Controller</code>
</PropertyNotSetInConstructor>
</file>
<file src="includes/sensei-functions.php">
<InvalidIterator occurrences="2">
<code>$base</code>
Expand Down Expand Up @@ -5798,7 +5795,8 @@
</RedundantCast>
</file>
<file src="includes/wpml/class-language-details.php">
<DocblockTypeContradiction occurrences="1">
<DocblockTypeContradiction occurrences="2">
<code>is_wp_error( $question_id )</code>
<code>is_wp_error( $question_id )</code>
</DocblockTypeContradiction>
</file>
Expand All @@ -5818,14 +5816,4 @@
<code>function wp_remote_request($url, $args = array())</code>
</InvalidDocblock>
</file>
<file src="includes/rest-api/class-sensei-rest-api-tour-controller.php">
<PropertyNotSetInConstructor occurrences="1">
<code>Sensei_REST_API_Tour_Controller</code>
</PropertyNotSetInConstructor>
</file>
<file src="includes/rest-api/class-sensei-rest-api-internal.php">
<PossiblyNullArgument occurrences="1">
<code>Sensei()->tour</code>
</PossiblyNullArgument>
</file>
</files>

0 comments on commit b13be20

Please sign in to comment.