Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sensei Compatible with all themes #2154

Closed
alexsanford opened this issue May 25, 2018 · 1 comment
Closed

Make Sensei Compatible with all themes #2154

alexsanford opened this issue May 25, 2018 · 1 comment

Comments

@alexsanford
Copy link
Contributor

alexsanford commented May 25, 2018

This issue is a description of what it will take in order to accomplish #2125.

For more depth, see p6rkRX-HY-p2.

In summary, we need to modify the frontend displays in Sensei which use full-page templates (e.g. the /courses/<course-slug> page which uses the single-course.php template). These full-page templates do not work properly in all themes.

Instead, we will use a similar approach to what WooCommerce adopted by rendering the content of these pages within the content area provided by the theme (e.g. using the the_content filter). This way, the theme will provide the proper layout, ensuring that the site looks good, and we will be simply adding our content within that layout. Note that we will only do this for themes that do not explicitly declare support for Sensei.

For full support, we will need to implement this rendering mechanism for all of the pages listed below. These may be done in multiple PR's.

Here is the initial PR that provides the architecture to build upon, and completes the Course Page. The Module Page is a work-in-progress and should have a PR soon as well. The remaining pages can be implemented in parallel.

@alexsanford
Copy link
Contributor Author

Well, looks like all the templates have been taken care of, and this long-lived issue has finally run its course 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants