Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Layout + Divi on Frontend & Editor: Review and adjust spacings and alignment for Divi #6856

Closed
merkushin opened this issue May 3, 2023 · 2 comments · Fixed by #6883
Assignees
Milestone

Comments

@merkushin
Copy link
Member

merkushin commented May 3, 2023

Depends on #6834

According to the provided design, apply spacing and alignment for the Standard Layout when using Divi theme.

Scope:

  • Apply spacing and alignment based on the design.
  • Desktop and mobile.
  • Divi theme.
  • Standard Layout.
  • Frontend & Editor

Design

Please check Figma for the design: 8mY8ui4zYK1Ylw2yIFi9Lx-fi-20020045_37699

@merkushin merkushin added this to the 4.14.0 milestone May 3, 2023
@gabrielcaires
Copy link
Contributor

gabrielcaires commented May 3, 2023

Already known issues on DIVI:

  • Header: In the design there is 8px of space between the site logo and the site title. On Divi there is 6.5px.
  • Header: There should be 16px between the lesson percentage text in the header and the Exit Course link. Currently there's 6.5px.
  • Sidebar: There's too much whitespace between the module name and the lesson name because the module has some bottom padding.
  • Content: There's only 32px between the bottom of the progress bar and the top of the lesson title, but it should be 56px.
  • Content: There should be 40px between the bottom of the lesson title and the start of the content, but there's only 10px.
  • Content: There's too much whitespace between the bottom of the content and the top of the lesson action buttons.
  • Content: The buttons are taller on Divi than they are on Astra. They should be about 48px high.

@github-actions
Copy link

Closed by #6883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants